fix: include wheel versions in deployment handoff by svvarom · Pull Request #818 · NVIDIA-NeMo/nemo-platform

svvarom · 2026-07-21T17:34:03Z

Summary

Release deployment events currently omit the wheel versions associated with the release, and wheel-only releases do not emit the handoff.

This change:

includes a wheel_versions map for every release containing wheels;
sends an empty map when a release contains no wheels; and
allows the handoff to run when wheels are available without a Helm chart.

This only adds release metadata. It does not change which wheels are selected, built, or published.

Testing

actionlint .github/workflows/release.yaml
cross-repository handoff contract tests
git diff --check

Summary by CodeRabbit

Bug Fixes
- Improved release deployment flow so deployments can proceed when Helm staging is skipped, while still requiring successful planning and final polling.
- Deployment creation events now more accurately reflect Helm availability (setting Helm version to null when Helm isn’t included).
- Wheel-related metadata is now passed with the dispatch event, including per-wheel version details when wheels are enabled.

Signed-off-by: Swarom Muley <smuley@nvidia.com>

coderabbitai · 2026-07-21T17:36:18Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

The release workflow broadens deployment dispatch gating and sends conditional Helm and wheel version data in the deployment event payload.

Changes

Release deployment dispatch

Layer / File(s)	Summary
Build and send release version mapping `.github/workflows/release.yaml`	The deployment job gates Helm and wheel releases, maps selected wheel IDs to `WHEEL_VERSION`, and sends conditional `helm_version` and `wheel_versions` data.

Possibly related PRs

NVIDIA-NeMo/nemo-platform#623: Introduced the unified release.yaml workflow updated here.
NVIDIA-NeMo/nemo-platform#678: Modified the same deployment signaling job and dispatch payload.

Suggested labels: ci

Suggested reviewers: crookedstorm, mckornfield

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title matches the main change: deployment handoff now includes wheel version data.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-sdk-version-handoff/svvarom

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-21T17:46:17Z

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	26396/34046	77.5%	61.7%
Integration Tests	15161/32671	46.4%	18.6%

Signed-off-by: Swarom Muley <smuley@nvidia.com>

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yaml:
- Around line 840-841: Update the signal-deployment job condition to use
always() and explicitly validate the required dependency results, including
allowing the wheel-only path when stage-helm is skipped. Preserve the existing
Helm and wheel eligibility checks while ensuring skipped stage-helm does not
suppress deployment signaling.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 75d807c4-be75-4b20-8edb-8174c8807a39

📥 Commits

Reviewing files that changed from the base of the PR and between 060526f and 5c7f0c2.

📒 Files selected for processing (1)

.github/workflows/release.yaml

Signed-off-by: Swarom Muley <smuley@nvidia.com>

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yaml:
- Around line 878-880: Update the payload field currently named wheel_versions
to sdk_versions, preserving its existing wheelVersions value so deployment
consumers receive the required SDK version mapping.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e0441903-d7f5-4e7a-b1d0-c7fa65fc1735

📥 Commits

Reviewing files that changed from the base of the PR and between 087e60a and 1df0732.

📒 Files selected for processing (1)

.github/workflows/release.yaml

crookedstorm · 2026-07-21T22:56:17Z

    name: Signal deployment
    needs: [plan-release, stage-helm, poll-final-release]
    if: >-
+      always() &&


let's not do this...that fights with cancelled logic

crookedstorm

To get the versions in the handoff from the same place where the containers are marked, i think this makes sense.

fix: include SDK versions in deployment handoff

d1da086

Signed-off-by: Swarom Muley <smuley@nvidia.com>

svvarom requested a review from a team as a code owner July 21, 2026 17:34

github-actions Bot added the fix label Jul 21, 2026

svvarom self-assigned this Jul 21, 2026

svvarom added 2 commits July 21, 2026 10:59

fix: include versions for wheel releases

060526f

Signed-off-by: Swarom Muley <smuley@nvidia.com>

fix: signal wheel-only releases

5c7f0c2

Signed-off-by: Swarom Muley <smuley@nvidia.com>

coderabbitai Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread .github/workflows/release.yaml

svvarom added 2 commits July 21, 2026 11:19

fix: handle skipped Helm stage in release signal

087e60a

Signed-off-by: Swarom Muley <smuley@nvidia.com>

fix: use wheel terminology in deployment handoff

1df0732

Signed-off-by: Swarom Muley <smuley@nvidia.com>

svvarom changed the title ~~fix: include SDK versions in deployment handoff~~ fix: include wheel versions in deployment handoff Jul 21, 2026

coderabbitai Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread .github/workflows/release.yaml

crookedstorm reviewed Jul 21, 2026

View reviewed changes

crookedstorm approved these changes Jul 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: include wheel versions in deployment handoff#818

fix: include wheel versions in deployment handoff#818
svvarom wants to merge 5 commits into
mainfrom
fix-sdk-version-handoff/svvarom

svvarom commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

crookedstorm Jul 21, 2026

Uh oh!

crookedstorm left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

svvarom commented Jul 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

crookedstorm Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

crookedstorm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

svvarom commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading